Anti-Pattern Scanner: An Approach to Detect Anti - swerl - TU Delft

145 Pages·2011·2.67 MB·English

Anti-Pattern Scanner: An Approach to
Detect Anti-Patterns and Design
Violations
Master’s Thesis
Ruben Wieman

Anti-Pattern Scanner: An Approach to
Detect Anti-Patterns and Design
Violations
THESIS
submittedinpartialfulfillmentofthe
requirementsforthedegreeof
MASTEROFSCIENCE
in
COMPUTERSCIENCE
by
RubenWieman
borninAlkmaar,theNetherlands
SoftwareEngineeringResearchGroup
DepartmentofSoftwareTechnology
FacultyEEMCS,DelftUniversityofTechnology
Delft,theNetherlands
www.ewi.tudelft.nl
©2011RubenWieman.
Anti-Pattern Scanner: An Approach to
Detect Anti-Patterns and Design
Violations
Author: RubenWieman
Studentid: 1150812
Email: [email protected]
Abstract
InthisMaster’sThesisProject,twoCodeSmells,fourAnti-Patternsandfourtypes
ofDesignPrincipleviolationshavebeenexamined.Wedevelopedadetectionprogram
calledtheAnti-PatternScanner. Thisscannerhasbeenusedinanempiricalevaluation
wherefiveopen-sourceJavaprojectshavebeenexaminedandscannedforthese‘pat-
tern’ problems. The results are that the examined problems generally do occur in
softwaresystems. Theproblemsareestimatedtobeinconvenienttosoftwaredevelop-
ment,dependingonthestrengthoftheirpresence. BasedontheAnti-PatternScanner
andtheresultsfromthisevaluation,suggestionsforfollow-upstudiesareoffered.
ThesisCommittee:
Chair: Prof. Dr. A.vanDeursen,FacultyEEMCS,TUDelft
Universitysupervisor: Dr. M.Pinzger,FacultyEEMCS,TUDelft
CommitteeMember: Dr.ir. A.J.H.Hidders,FacultyEEMCS,TUDelft

Preface
This Thesis document is the complete research report of the Master’s Thesis Project. This
Thesis is meant to support the candidature for an academic degree at the Delft University
of Technology. This document describes the exploratory research towards detection and
evaluationofsoftwaredesignproblems,suchasAnti-PatternsandsofwareDesignPrinciple
violations. Thisresearchaimstoanswerquestionsregardingwhetherthesedesignproblems
dooccurinprofessionalsoftwareprojectsandtoprovideanindicationwhethertheproblems
can be harmful to such a project. This work is based on tools being developed by the
SoftwareEngineeringResearchGroup(SERG)attheDelftUniversityofTechnology. This
researchalsoaimstocomplementrelatedworkandtoprovideabasisforfurtherresearch.
IwouldliketothankDr. M.Pinzgerforhissupervision,assistanceandexpertiseinthe
field of patterns and their detection. I would also like the thank Prof. Dr. A. van Deursen
forsupervisionandforhelpingmesetupthisprojectandDr.ir. A.J.H.Hiddersforhiswork
ascommitteemember.
RubenWieman
Delft,theNetherlands
April19,2011
iii

Contents
Preface iii
Contents v
ListofFigures vii
1 Introduction 1
1.1 Introduction . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 1
1.2 Introductiontopatterns,smellsandprinciples . . . . . . . . . . . . . . . . 2
1.3 Researchquestions . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 3
1.4 Contributions . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 3
2 RelatedWork 5
2.1 Approachesfordetectingpatterns . . . . . . . . . . . . . . . . . . . . . . 5
2.2 EarlierworkondetectingCodeSmellsandpatterns . . . . . . . . . . . . . 9
2.3 Faultpredictionandanalysis . . . . . . . . . . . . . . . . . . . . . . . . . 13
2.4 Evaluatingexistingtoolsforreuse . . . . . . . . . . . . . . . . . . . . . . 17
3 TheAnti-PatternScanner 21
3.1 Globaldesign . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 21
3.2 Implementation . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 28
4 Detectionstrategies 33
4.1 CodeSmells . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 34
4.2 Anti-Patterns . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 39
4.3 ClassDesignPrinciples . . . . . . . . . . . . . . . . . . . . . . . . . . . . 52
4.4 PackageCohesionPrinciples . . . . . . . . . . . . . . . . . . . . . . . . . 60
4.5 PackageCouplingPrinciples . . . . . . . . . . . . . . . . . . . . . . . . . 62
4.6 OtherPrinciples . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 65
v
CONTENTS
5 Empiricalevaluation 67
5.1 Casestudysetup . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 67
5.2 Detectedcases . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 71
5.3 Statistics . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 89
6 Discussionofresults 95
6.1 Evaluationofresults . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 95
6.2 Answersandvalidity . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 100
7 Conclusionandfuturework 103
7.1 Conclusion . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 103
7.2 Futurework . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 104
Bibliography 107
A Glossary 113
B Datasets 115
B.1 TheAnti-PatternScanner . . . . . . . . . . . . . . . . . . . . . . . . . . . 118
B.2 RaceCreationTool . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 120
B.3 NewNomadsDesktop . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 122
B.4 Tomcat . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 124
B.5 JForum . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 126
B.6 JUnit . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 128
B.7 JHotDraw . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 130
B.8 JMonkeyEngine . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 132
vi